Raise errors on unbound TypeVars with values #15732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
This comment has been minimized.
This comment has been minimized.
…into typevars-with-values
|
Diff from mypy_primer, showing the effect of this PR on open source code: mitmproxy (https://github.com/mitmproxy/mitmproxy)
+ mitmproxy/tools/console/grideditor/base.py:22: error: A function returning TypeVar should receive at least one argument containing the same TypeVar [type-var]
operator (https://github.com/canonical/operator)
+ ops/pebble.py:245: error: A function returning TypeVar should receive at least one argument containing the same TypeVar [type-var]
|
|
I will send them PRs with the fix. |
sobolevn
added a commit
to sobolevn/operator
that referenced
this pull request
Jul 21, 2023
Hi! While working on python/mypy#15732 our tools detected a misuse of `AnyStr` TypeVar (which is quite common). The proper way is to use `Union` here :)
sobolevn
added a commit
to sobolevn/mitmproxy
that referenced
this pull request
Jul 21, 2023
Hi! While working on python/mypy#15732 our tools detected a misuse of AnyStr TypeVar (which is quite common). The proper way here is to use `@overload`s :)
2 tasks
mhils
pushed a commit
to mitmproxy/mitmproxy
that referenced
this pull request
Jul 21, 2023
* Remove incorrect usage of `typing.AnyStr` Hi! While working on python/mypy#15732 our tools detected a misuse of AnyStr TypeVar (which is quite common). The proper way here is to use `@overload`s :) * [autofix.ci] apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
hauntsaninja
approved these changes
Jul 21, 2023
benhoyt
pushed a commit
to canonical/operator
that referenced
this pull request
Jul 24, 2023
Hi! While working on python/mypy#15732 our tools detected a misuse of `AnyStr` TypeVar (which is quite common). The proper way is to use `Union` here :)
lasting-yang
pushed a commit
to lasting-yang/mitmproxy
that referenced
this pull request
Aug 2, 2023
* Remove incorrect usage of `typing.AnyStr` Hi! While working on python/mypy#15732 our tools detected a misuse of AnyStr TypeVar (which is quite common). The proper way here is to use `@overload`s :) * [autofix.ci] apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes a
TODOitem :)Refs #15724